Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arguments maven2sbt is better than sbt-pom-reader #152

Closed
wants to merge 1 commit into from

Conversation

dev590t
Copy link

@dev590t dev590t commented Dec 12, 2020

This PR is related to #150

@kevin-lee
Copy link
Owner

Hi @zhenleibb,

Thank you so much for your kind words. Unfortunately, I'm not so comfortable with comparing my project with others and saying mine is better.

However, your words can be a very good testimonial or review so I'd like to add it to the website with your name if you don't mind.

So leave this PR for now and think about it. I'll get back to you once the reported bugs are all fixed. I'm working on it. 🙂

@dev590t
Copy link
Author

dev590t commented Dec 14, 2020

Thank you so much for your kind words. Unfortunately, I'm not so comfortable with comparing my project with others and saying mine is better.

Yes, you are right. I am not a good speaker, my manner to express my idea isn't top.
This PR is in order to give you the quality of the project in my mind. I have expected we discuss the PR before merge it. I just want show the quaity of the project, it is totally possible to show the quality without compared with others projects. As I am not a good speaker, I let you to reformulate it, or argue against it. I close the PR for the moment. We can continue to discuss in #150

However, your words can be a very good testimonial or review so I'd like to add it to the website with your name if you don't mind.

Thank you, I don't mind. 🙂

@dev590t dev590t closed this Dec 14, 2020
@kevin-lee
Copy link
Owner

@zhenleibb Oh... you didn't need to close this PR though. Your opinion is valuable. 🙂 I really appreciate it.
I'll provide a way that you can easily add it to the website and will let you know.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants