Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update system.md by adding NTP details #742

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Update system.md by adding NTP details #742

merged 1 commit into from
Oct 22, 2024

Conversation

axkar
Copy link
Collaborator

@axkar axkar commented Oct 21, 2024 •
edited
Loading

NTP functionality has been thoroughly verified and the proper documentation is added on:

  • Configuring NTP
  • Verifying NTP Status
  • Verifying NTP Sources

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@axkar axkar requested a review from troglobit October 21, 2024 10:44
@axkar axkar force-pushed the add-docs-ntp branch 2 times, most recently from acf57ee to 39e82e8 Compare October 21, 2024 10:48
@axkar axkar changed the title Update system.md with NTP Update system.md by adding NTP details Oct 21, 2024
troglobit
troglobit approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, nothing major, because overall it looks really good!

doc/networking.md Outdated Show resolved Hide resolved
doc/system.md Show resolved Hide resolved
doc/system.md Outdated Show resolved Hide resolved
doc/system.md Outdated Show resolved Hide resolved
doc/system.md Outdated Show resolved Hide resolved
doc/system.md Outdated Show resolved Hide resolved
doc/system.md Outdated Show resolved Hide resolved
doc/system.md Show resolved Hide resolved
@troglobit troglobit self-requested a review October 21, 2024 13:01
troglobit
troglobit requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Managed to click "approve" again instead of "request changes")

@axkar axkar self-assigned this Oct 21, 2024
@axkar
Copy link
Collaborator Author

axkar commented Oct 21, 2024

A few comments, nothing major, because overall it looks really good!

Thnx for all comment. Hope I have not forgotten anything :)

@axkar axkar requested a review from troglobit October 21, 2024 15:08
troglobit
troglobit requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this, almost there! 😃

doc/system.md Outdated Show resolved Hide resolved
troglobit
troglobit approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for hanging in there! 🎉

For future documentation only changes, consider adding the [skip ci] text to the body of your commit message(s), since there's no point in occupying the build and test servers.

@axkar
Copy link
Collaborator Author

axkar commented Oct 22, 2024

Great stuff, thanks for hanging in there! 🎉

For future documentation only changes, consider adding the [skip ci] text to the body of your commit message(s), since there's no point in occupying the build and test servers.

Yes, I'll do that :) Thnx

@axkar axkar merged commit 5c822ef into main Oct 22, 2024
6 checks passed
@axkar axkar deleted the add-docs-ntp branch October 22, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troglobit troglobit troglobit approved these changes

Assignees

@axkar axkar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axkar @troglobit