Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX : https://github.com/KenanY/json2toml/issues/92 #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

FIX : https://github.com/KenanY/json2toml/issues/92 #93

wants to merge 2 commits into from

Conversation

mcaruso85
Copy link
Contributor

@mcaruso85 mcaruso85 commented Jun 28, 2021 •
edited
Loading

There is no specification for mixed array in toml. So with this FIX when array is mixed, it behaves like before. If array is array of objects then it follows the spec to have the array of objects

So basically:

console.log(json2toml({"foo": [{"bar": false}, 9, true]}))
foo = [{"bar":false},9,true]

@mcaruso85 mcaruso85 mentioned this pull request Jun 28, 2021
Open
@kenany kenany self-assigned this Jul 15, 2021
@kenany kenany self-requested a review July 15, 2021 20:11
@kenany
Copy link
Owner

kenany commented Jul 15, 2021

Could you fix the merge conflicts?

kenany
kenany requested changes Dec 1, 2022
View reviewed changes
Copy link
Owner

@kenany kenany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenany kenany kenany requested changes

Assignees

@kenany kenany

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcaruso85 @kenany