fix: added fractional offset support

lib/time.js

@@ -152,17 +152,32 @@ function CronTime(luxon) {
 			}
 
 			if (typeof this.utcOffset !== 'undefined') {
-				let offset =
+				if (typeof this.utcOffset === 'string') {
+					const parts = this.utcOffset.split(':');
+					const hours = parseInt(parts[0]);
+					const minutes = parseInt(parts[1] ? parts[1] : '0');
+					if (this.utcOffset[0] === '-') this.utcOffset = hours * 60 - minutes;
+					else this.utcOffset = hours * 60 + minutes;
+				}
+
+				let offsetHours =
 					this.utcOffset >= 60 || this.utcOffset <= -60
 						? this.utcOffset / 60
 						: this.utcOffset;
-				offset = parseInt(offset);
+
+				offsetHours = parseInt(offsetHours);
+
+				const offsetMins = Math.abs(this.utcOffset - offsetHours * 60);
+				const offsetMinsStr = offsetMins >= 10 ? offsetMins : '0' + offsetMins;
 
 				let utcZone = 'UTC';
-				if (offset < 0) {
-					utcZone += offset;
-				} else if (offset > 0) {
-					utcZone += `+${offset}`;
+
+				if (this.utcOffset < 0) {
+					utcZone += `${
+						offsetHours === 0 ? '-0' : offsetHours
+					}:${offsetMinsStr}`;
+				} else {
+					utcZone += `+${offsetHours}:${offsetMinsStr}`;
 				}
 
 				date = date.setZone(utcZone);

tests/cron.test.js

@@ -379,7 +379,7 @@
 			const clock = sinon.useFakeTimers();
 			const callback = jest.fn();
 
-			var job = cron.job({
+			const job = cron.job({
 				cronTime: '* * * * * *',
 				onTick: callback,
 				runOnInit: true
@@ -799,6 +799,39 @@
 			expect(callback).toHaveBeenCalledTimes(1);
 		});
 
+		it('should run a job using cron syntax with numeric format utcOffset with minute', () => {
+			const clock = sinon.useFakeTimers();
+			const callback = jest.fn();
+
+			const luxon = require('luxon');
+			// Current time
+			const t = luxon.DateTime.local();
+			// UTC Offset decreased by 45 minutes
+			const utcOffset = t.offset - 45;
+
+			const job = new cron.CronJob(
+				t.second + ' ' + t.minute + ' ' + t.hour + ' * * *',
+				callback,
+				null,
+				true,
+				null,
+				null,
+				null,
+				utcOffset
+			);
+			// tick to 1s before 45 minutes
+			clock.tick(1000 * 60 * 45 - 1000);
+			expect(callback).toHaveBeenCalledTimes(0);
+
+			// tick 1s
+			clock.tick(1000);
+			expect(callback).toHaveBeenCalledTimes(1);
+
+			clock.restore();
+
+			job.stop();
+		});
+
 		it('should run a job using cron syntax with string format utcOffset', () => {
 			const clock = sinon.useFakeTimers();
 			const callback = jest.fn();
@@ -807,10 +840,7 @@
 			const t = luxon.DateTime.local();
 			// UTC Offset decreased by an hour (string format '(+/-)HH:mm')
 			const utcOffset = t.offset - 60;
-			let utcOffsetString = utcOffset > 0 ? '+' : '-';
-			utcOffsetString += ('0' + Math.floor(Math.abs(utcOffset) / 60)).slice(-2);
-			utcOffsetString += ':';
-			utcOffsetString += ('0' + (utcOffset % 60)).slice(-2);
+			const utcOffsetString = `${utcOffset > 0 ? '+' : '-'}${('0' + Math.floor(Math.abs(utcOffset) / 60)).slice(-2)}:${('0' + (utcOffset % 60)).slice(-2)}`;
 
 			const job = new cron.CronJob(
 				t.second + ' ' + t.minute + ' ' + t.hour + ' * * *',
@@ -834,11 +864,46 @@
 			expect(callback).toHaveBeenCalledTimes(1);
 		});
 
+		it('should run a job using cron syntax with string format utcOffset with minute', () => {
+			const clock = sinon.useFakeTimers();
+			const callback = jest.fn();
+
+			const luxon = require('luxon');
+			// Current time
+			const t = luxon.DateTime.local();
+			// UTC Offset decreased by 45 minutes (string format '(+/-)HH:mm')
+			const utcOffset = t.offset - 45;
+
+			const utcOffsetString = `${utcOffset > 0 ? '+' : '-'}${('0' + Math.floor(Math.abs(utcOffset) / 60)).slice(-2)}:${('0' + (utcOffset % 60)).slice(-2)}`;
+
+			const job = new cron.CronJob(
+				t.second + ' ' + t.minute + ' ' + t.hour + ' * * *',
+				callback,
+				null,
+				true,
+				null,
+				null,
+				null,
+				utcOffsetString
+			);
+			// tick to 1s before 45 minutes
+			clock.tick(1000 * 60 * 45 - 1000);
+			expect(callback).toHaveBeenCalledTimes(0);
+
+			// tick 1s
+			clock.tick(1000);
+			expect(callback).toHaveBeenCalledTimes(1);
+
+			clock.restore();
+
+			job.stop();
+		});
+
 		it('should run a job using cron syntax with number format utcOffset that is 0', () => {
 			const clock = sinon.useFakeTimers();
 			const callback = jest.fn();
 
 			const job = new cron.CronJob(
 				'* * * * * *',
 				callback,
 				null,

tests/crontime.test.js

@@ -634,18 +634,6 @@ describe('crontime', () => {
 		clock.restore();
 	});
 
-	it('should accept 4 as a valid UTC offset', () => {
-		const clock = sinon.useFakeTimers();
-
-		const cronTime = new cron.CronTime('0 11 * * *', null, 5);
-		const expected = luxon.DateTime.local().plus({ hours: 6 }).toSeconds();
-		const actual = cronTime.sendAt().toSeconds();
-
-		expect(actual).toEqual(expected);
-
-		clock.restore();
-	});
-
 	it('should detect real date in the past', () => {
 		const clock = sinon.useFakeTimers();