-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow soft warning when a hard error isn't required. #499
Conversation
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
- Coverage 92.35% 91.62% -0.74%
==========================================
Files 3 3
Lines 353 358 +5
Branches 102 104 +2
==========================================
+ Hits 326 328 +2
- Misses 26 28 +2
- Partials 1 2 +1
Continue to review full report at Codecov.
|
7a6f93b
to
b79391b
Compare
… hard error isn't required. Signed-off-by: Nick Campbell <[email protected]>
any update? |
Update? |
My hesitation with this PR is that it effectively reverts the change that was made to prevent infinite loops inside the cron tool. Of course this only happens in certain cases, and isn't all the time, but I want to support a better option. I'm thinking of making a change to this that resets the time by which the tool runs. I'll post here when I've settled on the best way to add this. Once I have a solution for this I'll push the code. |
@ncb000gt FYI it looks like this PR will always make In line 58 of If provided initially via an object, the softTimeout option |
🎉 This issue has been resolved in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
if anyone is curious on the decision making behind closing this PR check out this comment on #686 |
🎉 This issue has been resolved in version 3.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
GH-467 GH-478 GH-469 GH-470 GH-497 GH-498
Signed-off-by: Nick Campbell [email protected]