Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temp: no-op commit #4

Closed
wants to merge 70 commits into from
Closed

temp: no-op commit #4

wants to merge 70 commits into from
+1,208 −3,005

Commits on Feb 20, 2024

  1. feat: convert v2 content libraries to use Learning Core models

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    eccfb0a View commit details
    Browse the repository at this point in the history

  2. refactor: no need to spell out the app config when there's only one

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    82d7a30 View commit details
    Browse the repository at this point in the history

  3. chore: remove comment about libraries being blockstore-based

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f79b3cd View commit details
    Browse the repository at this point in the history

  4. test: fix model tests for content_libraries

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    21b7210 View commit details
    Browse the repository at this point in the history

  5. test: remove unnecessary mixin layering of test; remove parent/child … 

    …tests

(we don't support that)
    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8fd4718 View commit details
    Browse the repository at this point in the history

  6. fix: fix the filtering test case (requires change from openedx-learning)

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ce2a10c View commit details
    Browse the repository at this point in the history

  7. test: remove links-related tests (we no longer have them)

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    d9ba5be View commit details
    Browse the repository at this point in the history

  8. test: remove tests regarding library-type conversion (we're no longer… 

    … supporting that).
    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    952a3c3 View commit details
    Browse the repository at this point in the history

  9. test: more text patching

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    a560c0c View commit details
    Browse the repository at this point in the history

  10. fix: fix default xblock title behavior and adjust more tests

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    cdb7a9f View commit details
    Browse the repository at this point in the history

  11. fix: deleted blocks should 404 instead of 500

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5de9d46 View commit details
    Browse the repository at this point in the history

  12. feat!: remove blockstore lib import to learning core 

    There are no live v2 blockstore libraries that we're planning to
migrate.
    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    3f6fcbc View commit details
    Browse the repository at this point in the history

  13. refactor: adjust openedx-learning usage to match 0.6.0 changes

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    cbd3fe7 View commit details
    Browse the repository at this point in the history

  14. test: fix content_tagging tests to remove blockstore collection use

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    1583c25 View commit details
    Browse the repository at this point in the history

  15. test: remove test for v2 lib child block functionality (now unsupported)

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    0b7ccac View commit details
    Browse the repository at this point in the history

  16. test: remove blockstore usage from clipboard paste test

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    e0dca2a View commit details
    Browse the repository at this point in the history

  17. fix: remove atomic decorator from views

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    7ce6bfc View commit details
    Browse the repository at this point in the history

  18. refactor: shift library search logic from view to api

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f52a332 View commit details
    Browse the repository at this point in the history

  19. fix: force content libraries views to be nonatomic

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    51d69e5 View commit details
    Browse the repository at this point in the history

  20. refactor: remove unnecessary imports

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    cad1521 View commit details
    Browse the repository at this point in the history

  21. fix: have field data properly track changed fields (and simplify the … 

    …runtime/fielddata)
    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    706fa13 View commit details
    Browse the repository at this point in the history

  22. fix: remove error log that I was only using for debugging purposes

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2168c5e View commit details
    Browse the repository at this point in the history

  23. refactor: cleanups, comments

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    78c8b48 View commit details
    Browse the repository at this point in the history

  24. refactor: more comment tweaks

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    10ae9c5 View commit details
    Browse the repository at this point in the history

  25. refactor: more cleanup of config and removing debug comments

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f96ef5f View commit details
    Browse the repository at this point in the history

  26. refactor: more cleanup

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c05ed88 View commit details
    Browse the repository at this point in the history

  27. refactor: remove unused imports

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    44af99a View commit details
    Browse the repository at this point in the history

  28. refactor: update comments

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    cfe5a26 View commit details
    Browse the repository at this point in the history

  29. refactor: remove unnecessary atomic block

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    6157bea View commit details
    Browse the repository at this point in the history

  30. refactor: add comments to api calls, remove unused function

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    1b6ebbe View commit details
    Browse the repository at this point in the history

  31. refactor: changes in response to Kyle's review

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    bb3cdfd View commit details
    Browse the repository at this point in the history

  32. refactor: consolidate get_component_from_usage_key implementations

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    3ba8479 View commit details
    Browse the repository at this point in the history

  33. refactor: comment

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c4de68a View commit details
    Browse the repository at this point in the history

  34. refactor: remove get_block_display_name 

    It was previously being called with XBlocks or usage keys, at which
point, it would do a lookup of the display name from the Component. But
now it's only being sent XBlocks, and it only grabs their display_name
when that's the case, so there's no point in keeping it around.
    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2cf37f7 View commit details
    Browse the repository at this point in the history

  35. refactor: remove unnecessary config value for OPENEDX_LEARNING

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5cfbbd1 View commit details
    Browse the repository at this point in the history

  36. refactor: remove ENABLE_LIBRARY_AUTHORING_MICROFRONTEND from devstack… 

    … settings

(you have to add it to private.py)
    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    1eb2363 View commit details
    Browse the repository at this point in the history

  37. fix: make schema migration more backwards-compatible

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    0baee71 View commit details
    Browse the repository at this point in the history

  38. fix: add LC models to keyword overrides (I'm checking now if this is … 

    …okay)
    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    746e0ee View commit details
    Browse the repository at this point in the history

  39. fix: address linter errors

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    4e1205b View commit details
    Browse the repository at this point in the history

  40. fix: more linter fixes

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    d5481bc View commit details
    Browse the repository at this point in the history

  41. fix: more linter fixes

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    cf1aed9 View commit details
    Browse the repository at this point in the history

  42. fix: all the linter things

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    e5e2a94 View commit details
    Browse the repository at this point in the history

  43. fix: spacing

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f2b3ac5 View commit details
    Browse the repository at this point in the history

  44. fix: more linter fixes for indentation/spacing

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    11e802f View commit details
    Browse the repository at this point in the history

  45. fix: all the sytax linter stuff, I think...

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    42670a0 View commit details
    Browse the repository at this point in the history

  46. fix: remove entries from db_keyword_overrides (no longer necessary)

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8c43d7c View commit details
    Browse the repository at this point in the history

  47. chore: mypy thinks it's a BaseManager and not a ContentLibraryManager

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2ef2652 View commit details
    Browse the repository at this point in the history

  48. fix: skip the libraries test cases under LMS (signals won't get sent)

    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    53f0a33 View commit details
    Browse the repository at this point in the history

  49. refactor: re-order skip and ddt decorators in case that makes any dif… 

    …ference
    @ormsbee @kdmccormick
    ormsbee authored and kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    0f36be2 View commit details
    Browse the repository at this point in the history

  50. refactor: address some minor review comments 

    * specify 'draft' in docstring for get_library_block
* make create_component_for_block private
* delete leftover get_learning_context_impl comment
    @kdmccormick
    kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8c19357 View commit details
    Browse the repository at this point in the history

  51. refactor: get_library_block_olx -> get_block_draft_olx

    @kdmccormick
    kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    1582c30 View commit details
    Browse the repository at this point in the history

  52. test: use OpenEdxEventsTestMixin to fix content_libraries event testing 

    I'm not going to pretend I entirely understand this, but I'd like to get
tests passing first, and then worry about the details.
    @kdmccormick
    kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    21caa2e View commit details
    Browse the repository at this point in the history

  53. fix: raise a ValueError if block is set to OLX with the wrong XML tag

    @kdmccormick
    kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    1787959 View commit details
    Browse the repository at this point in the history

  54. fix: wrap _create_component_for_block in a transaction

    @kdmccormick
    kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    de72774 View commit details
    Browse the repository at this point in the history

  55. test: use non-ascii characters in library org, slug, and block id

    @kdmccormick
    kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    da3a49c View commit details
    Browse the repository at this point in the history

  56. refactor: don't import MediaType from models

    @kdmccormick
    kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    0d8ecb1 View commit details
    Browse the repository at this point in the history

  57. fix: fall back to type-defined block name if display_name missing

    @kdmccormick
    kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    12f138b View commit details
    Browse the repository at this point in the history

  58. fix: typo in get_block_display_name

    @kdmccormick
    kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    47cd922 View commit details
    Browse the repository at this point in the history

  59. test: fix non-ascii content_libraries tests

    @kdmccormick
    kdmccormick committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2b95faf View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. refactor: component_already_exists -> _component_exists

    @kdmccormick
    kdmccormick committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9ffa28d View commit details
    Browse the repository at this point in the history

  2. docs: add TODO comments - draft vs published, and deserialization

    @kdmccormick
    kdmccormick committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    60563aa View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into learning-core-lib… 

    …s-readwrite-runtime
    @kdmccormick
    kdmccormick committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    be1cacc View commit details
    Browse the repository at this point in the history

  4. feat: allow non-ascii block ids

    @kdmccormick
    kdmccormick authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3b48aa2 View commit details
    Browse the repository at this point in the history

  5. feat!: rm get_library_blocks

    @kdmccormick
    kdmccormick committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    c4a2c5c View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' into learning-core-lib… 

    …s-readwrite-runtime
    @kdmccormick
    kdmccormick committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7f65299 View commit details
    Browse the repository at this point in the history

  7. fix: typo -- left something commented out while testing

    @kdmccormick
    kdmccormick committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    47756a5 View commit details
    Browse the repository at this point in the history

  8. fix: only was conflicting with select_related

    @kdmccormick
    kdmccormick committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    76f8778 View commit details
    Browse the repository at this point in the history

  9. fix: final review comments

    @kdmccormick
    kdmccormick committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9829f60 View commit details
    Browse the repository at this point in the history

  10. temp: noop

    @kdmccormick
    kdmccormick committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    91b330c View commit details
    Browse the repository at this point in the history

  11. Merge branch 'learning-core-libs-readwrite-runtime' into kdmccormick/… 

    …noop
    @kdmccormick
    kdmccormick committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    4a32dc2 View commit details
    Browse the repository at this point in the history