Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed gist id must be a number and data-line not working #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

surdu
Copy link

@surdu surdu commented Jul 27, 2019

The following bugs where fixed:

  • data-line attribute not working anymore, probably due to layout change on GitHub's part
  • the id of a Gist is not an number only (anymore?). For example, this is a valid Gist id: aa01a6093a52b3fc7f6e91852beb9b69

The following improvements where added:

  • when removing the footer, also remove the double bottom border of the code snippet

@surdu
Copy link
Author

surdu commented Jul 27, 2019

I also removed this piece of code, as it looks like it did nothing useful. If I'm mistaken, please let me know and I'll revert the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant