Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/pkg/tasks/init: unit test cert #5625

Merged

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Sep 29, 2024

Description

In this commit, we introduce unit tests for the cert operator package, covering tasks such as creating new certificates, running existing certificates, and skipping certificates.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.
Depends on #5561 and #5630.

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.19%. Comparing base (517cb0d) to head (33b75f7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5625      +/-   ##
==========================================
+ Coverage   39.75%   40.19%   +0.44%     
==========================================
  Files         650      650              
  Lines       55147    55147              
==========================================
+ Hits        21924    22168     +244     
+ Misses      31815    31547     -268     
- Partials     1408     1432      +24     
Flag Coverage Δ
unittests 40.19% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah mohamedawnallah force-pushed the unitTestCertTaskInitOperatorPkg branch 3 times, most recently from 0753add to 6a76624 Compare October 1, 2024 13:05
@mohamedawnallah mohamedawnallah changed the title operator/pkg: unit test cert tasks operator/pkg/tasks/init: unit test cert Oct 6, 2024
Signed-off-by: Mohamed Awnallah <[email protected]>
@mohamedawnallah
Copy link
Contributor Author

cc @XiShanYongYe-Chang All test cases passed after PR #5561 was merged and rebasing on master branch :)

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@karmada-bot karmada-bot merged commit 98b600d into karmada-io:master Oct 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants