Merge pull request #5685 from LivingCcj/master

add ResourceSummary deep copy in general-estimator
karmada-io · Oct 21, 2024 · 6a827f6 · 6a827f6
2 parents aca83a7 + 3a4464a
commit 6a827f6
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/estimator/client/general.go b/pkg/estimator/client/general.go
@@ -54,7 +54,8 @@ func (ge *GeneralEstimator) MaxAvailableReplicas(_ context.Context, clusters []*
 }
 
 func (ge *GeneralEstimator) maxAvailableReplicas(cluster *clusterv1alpha1.Cluster, replicaRequirements *workv1alpha2.ReplicaRequirements) int32 {
- resourceSummary := cluster.Status.ResourceSummary
+ //Note: resourceSummary must be deep-copied before using in the function to avoid modifying the original data structure.
+ resourceSummary := cluster.Status.ResourceSummary.DeepCopy()
  if resourceSummary == nil {
  return 0
  }