Merge pull request #3781 from chaunceyjiang/mcs_port

feat: Change the port of MCS to required.
karmada-io · Jul 13, 2023 · 5326e1b · 5326e1b
2 parents a072609 + e4adcbe
commit 5326e1b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/charts/karmada/_crds/bases/networking/networking.karmada.io_multiclusterservices.yaml b/charts/karmada/_crds/bases/networking/networking.karmada.io_multiclusterservices.yaml
@@ -61,6 +61,8 @@ spec:
  description: Port specifies the exposed service port.
  format: int32
  type: integer
+ required:
+ - port
  type: object
  type: array
  range:

diff --git a/docs/proposals/networking/multiclusterservice.md b/docs/proposals/networking/multiclusterservice.md
@@ -128,8 +128,8 @@ type ExposurePort struct {
  Name string `json:"name,omitempty"`
 
  // Port specifies the exposed service port.
- // +optional
- Port int32 `json:"port,omitempty"`
+ // +required
+ Port int32 `json:"port"`
 }
 
 // ExposureRange describes a list of clusters where the service is exposed.
@@ -174,7 +174,7 @@ spec:
  ports:
  - port: 80
  types:
- - LoadBalance
+ - LoadBalancer
 ```
 
 ![image](statics/service-exposure.png)

diff --git a/pkg/apis/networking/v1alpha1/service_types.go b/pkg/apis/networking/v1alpha1/service_types.go
@@ -72,8 +72,8 @@ type ExposurePort struct {
  Name string `json:"name,omitempty"`
 
  // Port specifies the exposed service port.
- // +optional
- Port int32 `json:"port,omitempty"`
+ // +required
+ Port int32 `json:"port"`
 }
 
 // ExposureRange describes a list of clusters where the service is exposed.

diff --git a/pkg/generated/openapi/zz_generated.openapi.go b/pkg/generated/openapi/zz_generated.openapi.go