Improved connection info behavior.

kanata-php · Feb 24, 2024 · 4757bbf · 4757bbf
1 parent 059a822
commit 4757bbf
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/src/Constants.php b/src/Constants.php
@@ -93,4 +93,8 @@ class Constants
     // Action Events
 
     public const ACTION_EVENT_CHANNEL_PRESENCE = 'channel-presence';
+
+    // Reactive Actions
+
+    public const ACTION_CONNECTION_INFO = 'connection-info';
 }
diff --git a/src/ConveyorServer.php b/src/ConveyorServer.php
@@ -204,7 +204,7 @@ private function startServer(): void
             $fd = $request->fd;
             // @phpstan-ignore-next-line
             $this->server->defer(function () use ($fd) {
-                $action = 'connection-info';
+                $action = Constants::ACTION_CONNECTION_INFO;
                 $data = json_encode(['fd' => $fd, 'event' => $action]);
                 $hash = md5($data . time());
                 $this->server->push($fd, json_encode([

diff --git a/tests/Feature/OpenSwooleSocketTest.php b/tests/Feature/OpenSwooleSocketTest.php
@@ -188,6 +188,11 @@ public function testCanAddCustomActionThroughServer()
                     string $message,
                 ) use ($counter) {
                     $parsedData = json_decode($message, true);
+
+                    if ($parsedData['action'] === Constants::ACTION_CONNECTION_INFO) {
+                        return;
+                    }
+
                     $counter->add(1);
                     if ($parsedData['data'] === 'done') {
                         $counter->add(1);
@@ -254,6 +259,11 @@ functionToAdd: function (array $data) use ($expectedName) {
                     $expectedName
                 ) {
                     $parsedData = json_decode($message, true);
+
+                    if ($parsedData['action'] === Constants::ACTION_CONNECTION_INFO) {
+                        return;
+                    }
+
                     $counter->add(1);
                     if ($parsedData['data']['users'][1] === $expectedName) {
                         $counter->add(1);