Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable filtering of added rules via knobs in Settings #74

Merged
merged 14 commits into from
Jul 29, 2024

Conversation

kalmarek
Copy link
Owner

@kalmarek kalmarek commented Jul 25, 2024

This works for KBIndex only (and will stay like this)

  • document the feature.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 8 lines in your changes missing coverage. Please review.

Project coverage is 94.90%. Comparing base (f8e65d9) to head (6dc2632).

Files Patch % Lines
src/knuthbendix_idxA.jl 80.76% 5 Missing ⚠️
src/knuthbendix2.jl 75.00% 2 Missing ⚠️
src/rewriting.jl 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   94.80%   94.90%   +0.09%     
==========================================
  Files          30       30              
  Lines        1829     1883      +54     
==========================================
+ Hits         1734     1787      +53     
- Misses         95       96       +1     
Flag Coverage Δ
unittests 94.90% <90.90%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kalmarek kalmarek merged commit 690cfa8 into master Jul 29, 2024
19 checks passed
@kalmarek kalmarek deleted the mk/filter_rules branch October 23, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants