Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid overloading Base.union, Base.intersect and Base.contains #172

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Avoid overloading Base.union, Base.intersect and Base.contains #172

merged 3 commits into from
Oct 26, 2023

Commits on Oct 26, 2023

  1. Avoid overloading union, intersect and contains 

    For some of the motivation see #165. The main reason is that the union
and intersect methods in Base treat numbers as singleton containers,
which is different from the Arb versions.
    @Joel-Dahne
    Joel-Dahne committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    11fdee5 View commit details
    Browse the repository at this point in the history

  2. Documentation: Update documentation for union and intersection

    @Joel-Dahne
    Joel-Dahne committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d8455a2 View commit details
    Browse the repository at this point in the history

  3. Optimize multi-argument implementations of union and intersection 

    Also use that intersection! returns non-zero on failure, this avoids
checking overlap separately.
    @Joel-Dahne
    Joel-Dahne committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    7e9ec6b View commit details
    Browse the repository at this point in the history