Poly multiarg methods an optimizations #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should mention that this is based on the #159 PR, only the last two commits are new. I don't think there is a good way to mark this PR as being based on another PR and only show the differences unfortunately... |
kalmarek
reviewed
Oct 9, 2023
kalmarek
reviewed
Oct 9, 2023
kalmarek
reviewed
Oct 9, 2023
kalmarek
reviewed
Oct 9, 2023
kalmarek
approved these changes
Oct 9, 2023
|
@Joel-Dahne I think I've gone through most of this before and I see nothing contentious ;) Other than this this is ready to go. Kudos for tackling the documentation! |
Joel-Dahne
force-pushed
the
poly-multiarg
branch
from
05762c7
to
2b1b880
Compare
Joel-Dahne
force-pushed
the
poly-multiarg
branch
from
2b1b880
to
6f360f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the multi-argument addition and multiplication also for polynomials. I also noticed that
isnanandisfinitefor polynomials allocate a lot as written, so I added an optimization for that.This week I'm attending a Flint workshop so I will try to get as much work as possible done. You of course might not have the time to review everything, so I'll try to make successive PRs and then we can merge them one by one at some later stage.