Skip to content

Commit

Permalink
Aqua: Add excluded checks for ambiguities with comment about why
Browse files Browse the repository at this point in the history
  • Loading branch information
Joel-Dahne committed Apr 22, 2024
1 parent 3d70838 commit 1edf991
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,23 @@ DocMeta.setdocmeta!(Arblib, :DocTestSetup, :(using Arblib); recursive = true)

@testset "Arblib" begin
doctest(Arblib)
Aqua.test_all(Arblib; ambiguities = (; broken = true))
# Some methods are excluded from the check for ambiguities. There
# are two reasons for these exclusions, methods in Base we don't
# care about and false positives from Aqua.

# The methods in Base that we don't care about are construction
# from AbstractChar or Base.TwicePrecision. Both of these have
# default constructors for Number types that clash with our catch
# all constructors. They do not seem important enough to warrant
# extra code for handling them.

# One set of false positives are for Arf(::Rational) and
# Arb(::Rational). The other set is for + and * with mix of
# ArbSeries and AcbSeries.
Aqua.test_all(
Arblib,
ambiguities = (exclude = [Mag, Arf, Arb, Acb, ArbSeries, AcbSeries, +, *],),
)

include("ArbCall/runtests.jl")

Expand Down

0 comments on commit 1edf991

Please sign in to comment.