feat: add missing indexes to the oracle ddl script #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluwa
force-pushed
the
oracle-ddl-indexes
branch
from
f166c2d
to
81cf65f
Compare
kagkarlsson
approved these changes
Jul 2, 2024
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing indexes to the oracle ddl script
Every example for other databases (Postgres, Mssql, Mysql) contains indexes on
execution_timeandlast_heartbeatwhile for Oracle DB they are missing.I also expanded
DbUtiilsmethod to allow splitting sql statements from an sql file.jdbcRunner.execute(statement, NOOP)can run only one statement at a time for Oracle Db.PS: two tests for oracle db are failing on master, is that expected?
Reminders
mvn spotless:applycc @kagkarlsson