fix for ever growing list

kactus-io · Apr 3, 2020 · fca91ea · fca91ea
1 parent c1d5ddf
commit fca91ea
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 5 deletions.
diff --git a/app/package-lock.json b/app/package-lock.json
diff --git a/app/src/ui/lib/list/list.tsx b/app/src/ui/lib/list/list.tsx
@@ -300,10 +300,7 @@ export class List extends React.Component<IListProps, IListState> {
     const [width, height] = [target.offsetWidth, target.offsetHeight]
 
     if (this.state.width !== width || this.state.height !== height) {
-      this.setState({
-        width,
-        height: Math.min(height, window.outerHeight - 250 - 90),
-      })
+      this.setState({ width, height })
     }
   }
 

diff --git a/app/styles/ui/_file-list.scss b/app/styles/ui/_file-list.scss
@@ -11,6 +11,10 @@
   }
 
   .list-focus-container {
+    // hack to fix an ever growing list
+    // see https://github.com/kactus-io/kactus/issues/147
+    max-height: 1px;
+
     // Default to using status aware colors for the change type
     // octicons (i.e. green for added, yellowish for modified etc)
     // but fall back to picking up the ambient text color when the