Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Daemon redesign #788

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Daemon redesign #788

wants to merge 2 commits into from
+1,964 −2,019

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Oct 10, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 10, 2024
View reviewed changes
pkg/daemon/daemon.go Fixed Show fixed Hide fixed
@SchSeba SchSeba force-pushed the daemon_redesign branch 3 times, most recently from 9f5207e to 7d4e946 Compare October 10, 2024 10:23
@coveralls
Copy link

coveralls commented Oct 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11274292860

Details

  • 467 of 959 (48.7%) changed or added relevant lines in 16 files are covered.
  • 254 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+0.7%) to 45.7%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/host/internal/network/network.go 0 1 0.0%
pkg/daemon/config.go 30 32 93.75%
pkg/drain/drainer.go 12 14 85.71%
pkg/utils/cluster.go 27 32 84.38%
pkg/platforms/openshift/openshift.go 0 9 0.0%
pkg/daemon/status.go 43 61 70.49%
cmd/sriov-network-config-daemon/start.go 7 139 5.04%
controllers/drain_controller_helper.go 195 337 57.86%
pkg/daemon/daemon.go 116 297 39.06%
Files with Coverage Reduction New Missed Lines %
controllers/helper.go 1 71.96%
pkg/utils/cluster.go 3 41.73%
controllers/drain_controller.go 4 83.04%
api/v1/zz_generated.deepcopy.go 4 41.45%
pkg/client/clientset/versioned/fake/clientset_generated.go 5 46.15%
cmd/sriov-network-config-daemon/start.go 5 8.64%
pkg/client/informers/externalversions/sriovnetwork/interface.go 6 0.0%
pkg/plugins/fake/fake_plugin.go 6 20.0%
pkg/client/informers/externalversions/sriovnetwork/v1/interface.go 9 0.0%
pkg/client/clientset/versioned/typed/sriovnetwork/v1/fake/fake_sriovoperatorconfig.go 15 10.81%
Totals Coverage Status
Change from base Build 11258053806: 0.7%
Covered Lines: 6727
Relevant Lines: 14720
💛 - Coveralls

@SchSeba
This commit introduces a new redesign on how the operator resets the …
a0c5670 
…device plugin

* use a general nodeSelector to avoid updating the daemonset yaml
* remove the config-daemon removing pod (better security)
* make the operator in charge of resetting the device plugin via annotations
* mark the node as cordon BEFORE we remove the device plugin (without drain) to avoid scheduling new pods until the device plugin is backed up

Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba
WIP
ddc70f2 
Signed-off-by: Sebastian Sch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SchSeba @coveralls