Bump golangci to v1.59.1 #1599
Merged
Bump golangci to v1.59.1 #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
ytsarev and
jkremser
as code owners
kuritka
force-pushed
the
golangci-v1.59.1
branch
2 times, most recently
from
66ecace
to
a9e1361
Compare
I made the changes that were required to pass the linter. I removed the internal `directory` which hasn't made much sense for a long time. I've modified the GitHub action the new linter has depguard as the main change, which is a guard for imported packages. these must be explicitly enabled/disabled in the configuration. - https://golangci-lint.run/usage/linters/#depguard - https://github.com/OpenPeeDeeP/depguard Signed-off-by: Michal Kuritka <[email protected]>
kuritka
force-pushed
the
golangci-v1.59.1
branch
from
a9e1361
to
f93977c
Compare
|
@ytsarev amended. No worries, the changes may go little against each other as I did in separate PR's, so rebasing is in plan. |
ytsarev
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the changes that were required to pass the linter. I removed the internal
directorywhich hasn't made much sense for a long time. I've modified the GitHub actionthe new linter has depguard as the main change, which is a guard for imported packages. these must be explicitly enabled/disabled in the configuration.