perf: disable stack at proper lines

k644606347 · Sep 18, 2023 · c6fb527 · c6fb527
1 parent 89133b5
commit c6fb527
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 18 deletions.
diff --git a/packages/g6/src/stdlib/behavior/drag-canvas.ts b/packages/g6/src/stdlib/behavior/drag-canvas.ts
@@ -165,12 +165,12 @@ export class DragCanvas extends Behavior {
  return;
  }
  const section = sections.shift();
- graph.hideItem(section, false, true);
+ graph.executeWithNoStack(() => {
+ graph.hideItem(section, false, true);
+ });
  requestId = requestAnimationFrame(update);
  };
- graph.executeWithNoStack(() => {
- requestId = requestAnimationFrame(update);
- });
+ requestId = requestAnimationFrame(update);
  }
  }
 
@@ -285,12 +285,12 @@ export class DragCanvas extends Behavior {
  cancelAnimationFrame(requestId);
  return;
  }
+ graph.startHistoryBatch();
  graph.showItem(sections.shift(), false);
+ graph.stopHistoryBatch();
  requestId = requestAnimationFrame(update);
  };
- graph.startHistoryBatch();
  requestId = requestAnimationFrame(update);
- graph.stopHistoryBatch();
  }
  }
  }

diff --git a/packages/g6/src/stdlib/behavior/scroll-canvas.ts b/packages/g6/src/stdlib/behavior/scroll-canvas.ts
@@ -259,12 +259,12 @@ export class ScrollCanvas extends Behavior {
  return;
  }
  const section = sections.shift();
+ graph.startHistoryBatch();
  graph.hideItem(section, false, true);
+ graph.stopHistoryBatch();
  requestId = requestAnimationFrame(update);
  };
- graph.startHistoryBatch();
  requestId = requestAnimationFrame(update);
- graph.stopHistoryBatch();
 
  if (currentZoom < optimizeZoom) {
  this.hiddenNodeIds.push(...newHiddenNodeIds);
@@ -309,12 +309,12 @@ export class ScrollCanvas extends Behavior {
  cancelAnimationFrame(requestId);
  return;
  }
- graph.showItem(sections.shift(), false);
+ graph.executeWithNoStack(() => {
+ graph.showItem(sections.shift(), false);
+ });
  requestId = requestAnimationFrame(update);
  };
- graph.executeWithNoStack(() => {
- requestId = requestAnimationFrame(update);
- });
+ requestId = requestAnimationFrame(update);
 
  this.hiddenEdgeIds = this.hiddenNodeIds = [];
  }

diff --git a/packages/g6/src/stdlib/behavior/zoom-canvas.ts b/packages/g6/src/stdlib/behavior/zoom-canvas.ts
@@ -146,12 +146,12 @@ export class ZoomCanvas extends Behavior {
  return;
  }
  const section = sections.shift();
+ graph.startHistoryBatch();
  graph.hideItem(section, false, true);
+ graph.stopHistoryBatch();
  requestId = requestAnimationFrame(update);
  };
- graph.startHistoryBatch();
  requestId = requestAnimationFrame(update);
- graph.stopHistoryBatch();
  }
  }
 
@@ -180,12 +180,12 @@ export class ZoomCanvas extends Behavior {
  cancelAnimationFrame(requestId);
  return;
  }
- graph.showItem(sections.shift(), false);
+ graph.executeWithNoStack(() => {
+ graph.showItem(sections.shift(), false);
+ });
  requestId = requestAnimationFrame(update);
  };
- graph.executeWithNoStack(() => {
- requestId = requestAnimationFrame(update);
- });
+ requestId = requestAnimationFrame(update);
  }
  }
  this.hiddenEdgeIds = [];