Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 1: Show how to use OCI registries via plain HTTP #5107

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 10, 2024

Description

OCI registries use HTTPS by default. We forgot to specify how to turn this off, if desired.

Proposal: Use a custom URL scheme (oci+http) to turn this off and fall back to plain HTTP.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

OCI registries use HTTPS by default. Use a custom URL scheme to turn
this off and fall back to plain HTTP.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 requested review from a team as code owners October 10, 2024 13:49
@twz123 twz123 changed the title Show how to use OCI registries via plain HTTP ADR 1: Show how to use OCI registries via plain HTTP Oct 10, 2024
@ricardomaraschini ricardomaraschini merged commit 6b72bf4 into k0sproject:main Oct 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants