Reuse the reader returned by FetchReference #5102
Merged
Commits on Oct 10, 2024
-
Reuse the reader returned by FetchReference
FetchReference already returns a reader to the manifest content. However, content.Successors operates on a Fetcher. In order to funnel the already open reader into content.Successors, create a FetcherFunc that returns it. This saves one additional GET request. Before: GET /v2/repository/artifact/manifests/latest GET /v2/repository/artifact/manifests/sha256:341098d11767212bb4d148f3fe8e82fc2939c3be247b233291a62e39a594ed09 GET /v2/repository/artifact/blobs/sha256:9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08 After: GET /v2/repository/artifact/manifests/latest GET /v2/repository/artifact/blobs/sha256:9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08 Signed-off-by: Tom Wieczorek <[email protected]> -
They increase coverage slightly from 85.7% to 87%. Signed-off-by: Tom Wieczorek <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.