Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make possible to build with podman or without docker #5096

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make possible to build with podman or without docker #5096

wants to merge 2 commits into from
+31 −23

Conversation

ncopa
Copy link
Collaborator

@ncopa ncopa commented Oct 9, 2024

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ncopa
Use a variable for docker runtime
feb79f5 
This makes it possible to use podman.

Signed-off-by: Natanael Copa <[email protected]>
@ncopa ncopa requested a review from a team as a code owner October 9, 2024 11:42
@ncopa
Support build k0s without docker
2cd152d 
Disable use of docker by running: make DOCKER=false
This will also disable the embedded bins.

Signed-off-by: Natanael Copa <[email protected]>
@ncopa ncopa added the chore label Nov 5, 2024
@ncopa ncopa added this to the 1.32 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twz123 twz123 Awaiting requested review from twz123 twz123 is a code owner automatically assigned from k0sproject/k0s-maintainers

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas juanluisvaladas is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
1 participant
@ncopa