Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline manifestsSaver #5063

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Inline manifestsSaver #5063

wants to merge 6 commits into from

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 2, 2024 •
edited
Loading

Description

This makes the components more self-contained and gives them more control over the contents of the directories. Also, the FsManifestsSaver did not use the ManifestsDir configuration field.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 changed the title Inline manifestSsaver Inline manifestsSaver Oct 2, 2024
@twz123 twz123 marked this pull request as ready for review October 2, 2024 11:18
@twz123 twz123 requested a review from a team as a code owner October 2, 2024 11:18
@twz123 twz123 requested review from ncopa and makhov October 2, 2024 11:18
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@twz123
Inline manifestsSaver into the CRD component
ae964ac 
The manifestSaver abstraction was not serving any special purpose for
the CRDs. Inlining it makes the code more straightforward.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Inline manifestsSaver into the KubeRouter component
451b53d 
Adjust the tests to use temporary directories and let them call all the
lifecycle methods.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Inline manifestsSaver into the Windows stack component
644bce6 
The manifestSaver abstraction was not serving any special purpose.
Inlining it makes the code more straightforward.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Inline manifestsSaver into the Calico component
d862edd 
Adjust the tests to use temporary directories and let them call all the
lifecycle methods.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Inline manifestsSaver into the Metrics component
a3465ff 
The manifestSaver abstraction was not serving any special purpose.
Inlining it makes the code more straightforward.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Remove the now unused manifestsSaver
ad3fd24 
Its functionality has been inlined into the components.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 requested a review from a team as a code owner October 31, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/controlplane chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twz123