feat(router): Add payments get-intent API for v2 #6396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperswitch-bot
bot
added
the
M-api-contract-changes
AnuthaDev
force-pushed
the
get-intent-v2
branch
from
ee3e783
to
3fb466e
Compare
AnuthaDev
commented
Oct 23, 2024
| @@ -57,7 +57,7 @@ pub struct CalculateTax; | |||
| pub struct SdkSessionUpdate; | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
| pub struct CreateIntent; | |||
| pub struct Intent; | |||
There was a problem hiding this comment.
Is this OK or should this be PaymentsIntent instead? Or we need separate CreateIntent and GetIntent?
| params (("id" = String, Path, description = "The unique identifier for the Payment Intent")), | ||
| responses( | ||
| (status = 200, description = "Payment Intent", body = PaymentsIntentResponse), | ||
| (status = 404, description = "Payment ID not found") |
There was a problem hiding this comment.
Should this be 400 instead? What all status codes need to be mentioned here?
| .find_payment_intent_by_id(key_manager_state, &request.id, key_store, storage_scheme) | ||
| .await | ||
| .change_context(errors::ApiErrorResponse::InternalServerError) | ||
| .attach_printable("Payment Intent Not Found")?; |
There was a problem hiding this comment.
This feels incomplete?
| errors::StorageError, | ||
| > { | ||
| // validate customer_id if sent in the request | ||
| if let Some(id) = payment_data.payment_intent.customer_id.clone() { |
There was a problem hiding this comment.
This shouldn't be needed for GetIntent. Should I remove this?
AnuthaDev
commented
Oct 23, 2024
| impl ApiEventMetric for PaymentsGetIntentRequest { | ||
| fn get_api_event_type(&self) -> Option<ApiEventsType> { | ||
| Some(ApiEventsType::Payment { | ||
| payment_id: self.id.clone(), |
There was a problem hiding this comment.
Should this be a reference instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added
get-intentAPI for paymentsAdditional Changes
Motivation and Context
Closes #6395
How did you test it?
1a. Request
1b. Response
{ "id": "12345_pay_0192b3a0145173519abaa04d4b939558", "amount_details": { "order_amount": { "Value": 100 }, "currency": "USD", "shipping_cost": null, "order_tax_amount": null, "skip_external_tax_calculation": "Skip", "skip_surcharge_calculation": "Skip", "surcharge_amount": null, "tax_on_surcharge": null }, "client_secret": "12345_pay_0192b3a0145173519abaa04d4b939558_secret_0192b3a0145173519abaa05c07ec3e61", "merchant_reference_id": null, "routing_algorithm_id": null, "capture_method": "automatic", "authentication_type": "no_three_ds", "billing": null, "shipping": null, "customer_id": null, "customer_present": "Present", "description": null, "return_url": null, "setup_future_usage": "on_session", "apply_mit_exemption": "Skip", "statement_descriptor": null, "order_details": null, "allowed_payment_method_types": null, "metadata": null, "connector_metadata": null, "feature_metadata": null, "payment_link_enabled": "Skip", "payment_link_config": null, "request_incremental_authorization": "default", "expires_on": "2024-10-22T10:02:45.618Z", "frm_metadata": null, "request_external_three_ds_authentication": "Skip" }Checklist
cargo +nightly fmt --allcargo clippy