Add missing tool paths to the PATH #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #255.
This PR fixes the behavior of the
add-tools-to-pathoption for a few tools where it currently does not work. These tools include:Tools/Ninja/ninjaTools/Conan/conanTools/CMake/CMake.app, which is not whereinstall-qt-actioncurrently looks for it, parallel to theToolsdirectory.This PR also adds tests to check that these tools are installed, executable, and in the PATH when
add-tools-to-pathis set.It is still possible that there are other tools somewhere in the Qt repo that aren't being added to the PATH properly; I have not exhaustively searched them. If there are more such tools, it should not be too difficult to modify this code to fix them.