Reset vocoder phase buffer on pitch shifting factor change #45

jurihock · Dec 11, 2023 · b5b1f69 · b5b1f69
1 parent 8f64741
commit b5b1f69
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/cpp/StftPitchShift/StftPitchShiftCore.h b/cpp/StftPitchShift/StftPitchShiftCore.h
@@ -78,6 +78,7 @@ namespace stftpitchshift
     void factors(const std::vector<double>& factors)
     {
       pitcher.factors(factors);
+      vocoder.reset(); // #45
     }
 
     double quefrency() const

diff --git a/cpp/StftPitchShift/Vocoder.h b/cpp/StftPitchShift/Vocoder.h
@@ -1,5 +1,6 @@
 #pragma once
 
+#include <algorithm>
 #include <cassert>
 #include <cmath>
 #include <complex>
@@ -45,6 +46,12 @@ namespace stftpitchshift
       }
     }
 
+    void reset()
+    {
+      // zero decode phase buffer according to #45
+      std::fill(decode_phase_buffer.begin(), decode_phase_buffer.end(), 0);
+    }
+
     void encode(const std::span<std::complex<T>> dft)
     {
       assert(dft.size() == encode_phase_buffer.size());