Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bail early when running all tests #707

Merged

Conversation

fcollonval
Copy link
Member

Follow-up of https://github.com/jupyterlab/lumino/actions/runs/9294642763/job/25580176911?pr=706

Tests were skipped due to a failure in one of the package:

 >  Lerna (powered by Nx)   Running target test:webkit for 16 projects failed

   Tasks not run because their dependencies failed or --nx-bail=true:
   
   - @lumino/application:test:webkit
   - @lumino/polling:test:webkit
   
   Failed tasks:
   
   - @lumino/datagrid:test:webkit

We should run all tests on the CI to capture all failures at once.

@fcollonval fcollonval added the maintenance Dependencies, build, technical debt, etc. label May 30, 2024
@fcollonval fcollonval merged commit 79e0ed8 into jupyterlab:main Jun 2, 2024
19 checks passed
@fcollonval fcollonval deleted the maintenance/improve-test-execution branch June 2, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant