Make keyboard layouts in charge of modifier keys and formatting of keys #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the commands package is in charge of formatting a keyboard shortcut for display and hard-coding the modifiers for a keyboard shortcut. However, this means that the modifiers and how keyboard keys are displayed are both hard-coded in the command package rather than being specified in the keyboard layout, which is closer to the keyboard capabilities.
I think ideally, the keyboard layout should be responsible for encoding the capabilities of the keyboard, including what the modifier keys are and how keys are displayed. This PR explores how this might work.
A couple of notes and unfinished business:
It may be that when we are ready to support keyboard layouts with other modifiers, it is appropriate to switch from using
.keyCode
to.key
, which may make this PR obsolete.