Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number cell input's step can be set using metadata #118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kgoo124
Copy link
Contributor

@kgoo124 kgoo124 commented Aug 21, 2020

Currently, the number cell editor automatically uses step of 'any'. This results in the step for a decimal number always being 1. I figured I would try to tackle this problem at the source.

This PR allows a step to be passed into the metadata for a cell. If no step is found, it will default to any.

@lmcnichols @ryuntalan

@kgoo124
Copy link
Contributor Author

kgoo124 commented Aug 21, 2020

We could also get smarter and have the NumberCellEditor calculate what the step is based on how many decimal places are in the current value.

Example:
10.23 => 2 decimal places, step = "0.01"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant