Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce body _pollution_ with design tokens #127

Closed
wants to merge 1 commit into from
Closed

Reduce body _pollution_ with design tokens #127

wants to merge 1 commit into from

Conversation

fcollonval
Copy link
Member

No description provided.

@fcollonval fcollonval added the bug Something isn't working label Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Binder 👈 Launch a Binder on branch jupyterlab-contrib/jupyter-ui-toolkit/fix/set-design-token-on-default-element

@fcollonval
Copy link
Member Author

Closing as we read the value of token for document.body, this therefore create a designnode on it. Hence the CSS property will be set anyway.

@fcollonval fcollonval closed this Aug 10, 2024
@fcollonval fcollonval deleted the fix/set-design-token-on-default-element branch August 10, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fcollonval