Skip to content

Don't make the toolbar stands out of its parent #390

Don't make the toolbar stands out of its parent

Don't make the toolbar stands out of its parent #390

Triggered via pull request August 9, 2024 09:06
Status Failure
Total duration 12m 39s
Artifacts 1

visual-test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

13 errors, 8 warnings, and 2 notices
[chromium] › src/avatar/avatar.test.ts:22:1 › With Image: packages/components/src/avatar/avatar.test.ts#L25
1) [chromium] › src/avatar/avatar.test.ts:22:1 › With Image ────────────────────────────────────── Error: Screenshot comparison failed: 666 pixels (ratio 0.66 of all image pixels) are different. Expected: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-chromium/avatar-with-image-expected.png Received: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-chromium/avatar-with-image-actual.png Diff: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-chromium/avatar-with-image-diff.png 23 | await page.goto('/iframe.html?id=components-avatar--with-image'); 24 | > 25 | expect(await page.locator('jp-avatar').screenshot()).toMatchSnapshot( | ^ 26 | 'avatar-with-image.png' 27 | ); 28 | }); at /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/src/avatar/avatar.test.ts:25:56
[chromium] › src/avatar/avatar.test.ts:22:1 › With Image: packages/components/src/avatar/avatar.test.ts#L25
1) [chromium] › src/avatar/avatar.test.ts:22:1 › With Image ────────────────────────────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 666 pixels (ratio 0.66 of all image pixels) are different. Expected: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-chromium-retry1/avatar-with-image-expected.png Received: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-chromium-retry1/avatar-with-image-actual.png Diff: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-chromium-retry1/avatar-with-image-diff.png 23 | await page.goto('/iframe.html?id=components-avatar--with-image'); 24 | > 25 | expect(await page.locator('jp-avatar').screenshot()).toMatchSnapshot( | ^ 26 | 'avatar-with-image.png' 27 | ); 28 | }); at /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/src/avatar/avatar.test.ts:25:56
[chromium] › src/avatar/avatar.test.ts:22:1 › With Image: packages/components/src/avatar/avatar.test.ts#L25
1) [chromium] › src/avatar/avatar.test.ts:22:1 › With Image ────────────────────────────────────── Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 666 pixels (ratio 0.66 of all image pixels) are different. Expected: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-chromium-retry2/avatar-with-image-expected.png Received: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-chromium-retry2/avatar-with-image-actual.png Diff: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-chromium-retry2/avatar-with-image-diff.png 23 | await page.goto('/iframe.html?id=components-avatar--with-image'); 24 | > 25 | expect(await page.locator('jp-avatar').screenshot()).toMatchSnapshot( | ^ 26 | 'avatar-with-image.png' 27 | ); 28 | }); at /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/src/avatar/avatar.test.ts:25:56
[firefox] › src/avatar/avatar.test.ts:22:1 › With Image: packages/components/src/avatar/avatar.test.ts#L25
2) [firefox] › src/avatar/avatar.test.ts:22:1 › With Image ─────────────────────────────────────── Error: Screenshot comparison failed: 666 pixels (ratio 0.66 of all image pixels) are different. Expected: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-firefox/avatar-with-image-expected.png Received: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-firefox/avatar-with-image-actual.png Diff: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-firefox/avatar-with-image-diff.png 23 | await page.goto('/iframe.html?id=components-avatar--with-image'); 24 | > 25 | expect(await page.locator('jp-avatar').screenshot()).toMatchSnapshot( | ^ 26 | 'avatar-with-image.png' 27 | ); 28 | }); at /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/src/avatar/avatar.test.ts:25:56
[firefox] › src/avatar/avatar.test.ts:22:1 › With Image: packages/components/src/avatar/avatar.test.ts#L25
2) [firefox] › src/avatar/avatar.test.ts:22:1 › With Image ─────────────────────────────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 666 pixels (ratio 0.66 of all image pixels) are different. Expected: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-firefox-retry1/avatar-with-image-expected.png Received: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-firefox-retry1/avatar-with-image-actual.png Diff: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-firefox-retry1/avatar-with-image-diff.png 23 | await page.goto('/iframe.html?id=components-avatar--with-image'); 24 | > 25 | expect(await page.locator('jp-avatar').screenshot()).toMatchSnapshot( | ^ 26 | 'avatar-with-image.png' 27 | ); 28 | }); at /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/src/avatar/avatar.test.ts:25:56
[firefox] › src/avatar/avatar.test.ts:22:1 › With Image: packages/components/src/avatar/avatar.test.ts#L25
2) [firefox] › src/avatar/avatar.test.ts:22:1 › With Image ─────────────────────────────────────── Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 666 pixels (ratio 0.66 of all image pixels) are different. Expected: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-firefox-retry2/avatar-with-image-expected.png Received: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-firefox-retry2/avatar-with-image-actual.png Diff: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-avatar-avatar-With-Image-firefox-retry2/avatar-with-image-diff.png 23 | await page.goto('/iframe.html?id=components-avatar--with-image'); 24 | > 25 | expect(await page.locator('jp-avatar').screenshot()).toMatchSnapshot( | ^ 26 | 'avatar-with-image.png' 27 | ); 28 | }); at /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/src/avatar/avatar.test.ts:25:56
[webkit] › src/slider-label/slider-label.test.ts:14:1 › With Hide Mark: packages/components/src/slider-label/slider-label.test.ts#L17
3) [webkit] › src/slider-label/slider-label.test.ts:14:1 › With Hide Mark ──────────────────────── Error: Screenshot comparison failed: 166656 pixels (ratio 0.61 of all image pixels) are different. Expected: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-slider-label-slider-label-With-Hide-Mark-webkit/slider-label-with-hide-mark-expected.png Received: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-slider-label-slider-label-With-Hide-Mark-webkit/slider-label-with-hide-mark-actual.png Diff: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-slider-label-slider-label-With-Hide-Mark-webkit/slider-label-with-hide-mark-diff.png 15 | await page.goto('/iframe.html?id=components-slider-label--with-hide-mark'); 16 | > 17 | expect(await page.locator('body').screenshot()).toMatchSnapshot( | ^ 18 | 'slider-label-with-hide-mark.png' 19 | ); 20 | }); at /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/src/slider-label/slider-label.test.ts:17:51
[webkit] › src/slider-label/slider-label.test.ts:14:1 › With Hide Mark: packages/components/src/slider-label/slider-label.test.ts#L17
3) [webkit] › src/slider-label/slider-label.test.ts:14:1 › With Hide Mark ──────────────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 166656 pixels (ratio 0.61 of all image pixels) are different. Expected: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-slider-label-slider-label-With-Hide-Mark-webkit-retry1/slider-label-with-hide-mark-expected.png Received: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-slider-label-slider-label-With-Hide-Mark-webkit-retry1/slider-label-with-hide-mark-actual.png Diff: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-slider-label-slider-label-With-Hide-Mark-webkit-retry1/slider-label-with-hide-mark-diff.png 15 | await page.goto('/iframe.html?id=components-slider-label--with-hide-mark'); 16 | > 17 | expect(await page.locator('body').screenshot()).toMatchSnapshot( | ^ 18 | 'slider-label-with-hide-mark.png' 19 | ); 20 | }); at /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/src/slider-label/slider-label.test.ts:17:51
[webkit] › src/slider-label/slider-label.test.ts:14:1 › With Hide Mark: packages/components/src/slider-label/slider-label.test.ts#L17
3) [webkit] › src/slider-label/slider-label.test.ts:14:1 › With Hide Mark ──────────────────────── Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 166656 pixels (ratio 0.61 of all image pixels) are different. Expected: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-slider-label-slider-label-With-Hide-Mark-webkit-retry2/slider-label-with-hide-mark-expected.png Received: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-slider-label-slider-label-With-Hide-Mark-webkit-retry2/slider-label-with-hide-mark-actual.png Diff: /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/test-results/src-slider-label-slider-label-With-Hide-Mark-webkit-retry2/slider-label-with-hide-mark-diff.png 15 | await page.goto('/iframe.html?id=components-slider-label--with-hide-mark'); 16 | > 17 | expect(await page.locator('body').screenshot()).toMatchSnapshot( | ^ 18 | 'slider-label-with-hide-mark.png' 19 | ); 20 | }); at /home/runner/work/jupyter-ui-toolkit/jupyter-ui-toolkit/packages/components/src/slider-label/slider-label.test.ts:17:51
[chromium] › src/anchor/anchor.base.test.ts:29:3 › jpAnchor › receive focus when focused programatically: packages/components/src/anchor/anchor.base.test.ts#L1
4) [chromium] › src/anchor/anchor.base.test.ts:29:3 › jpAnchor › receive focus when focused programatically Test timeout of 30000ms exceeded.
[webkit] › src/anchor/anchor.base.test.ts:29:3 › jpAnchor › receive focus when focused programatically: packages/components/src/anchor/anchor.base.test.ts#L1
1) [webkit] › src/anchor/anchor.base.test.ts:29:3 › jpAnchor › receive focus when focused programatically Test timeout of 30000ms exceeded.
[webkit] › src/anchor/anchor.base.test.ts:29:3 › jpAnchor › receive focus when focused programatically: packages/components/src/anchor/anchor.base.test.ts#L31
1) [webkit] › src/anchor/anchor.base.test.ts:29:3 › jpAnchor › receive focus when focused programatically Error: locator.waitFor: Target closed =========================== logs =========================== waiting for locator('jp-anchor') to be visible locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolved to hidden <jp-anchor href="#" id="anchor1" class="neutral" appearance…>Hello</jp-anchor> locator resolve
[webkit] › src/anchor/anchor.base.test.ts:29:3 › jpAnchor › receive focus when focused programatically: packages/components/src/anchor/anchor.base.test.ts#L1
1) [webkit] › src/anchor/anchor.base.test.ts:29:3 › jpAnchor › receive focus when focused programatically Pending operations: - locator.waitFor at src/anchor/anchor.base.test.ts:31:19
visual-test
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Slow Test: packages/components/[webkit] › src/anchor/anchor.base.test.ts#L1
packages/components/[webkit] › src/anchor/anchor.base.test.ts took 32.4s
Slow Test: packages/components/[chromium] › src/anchor/anchor.base.test.ts#L1
packages/components/[chromium] › src/anchor/anchor.base.test.ts took 31.4s
Slow Test: packages/components/[firefox] › src/select/select.base.test.ts#L1
packages/components/[firefox] › src/select/select.base.test.ts took 23.1s
Slow Test: packages/components/[webkit] › src/select/select.base.test.ts#L1
packages/components/[webkit] › src/select/select.base.test.ts took 22.7s
Slow Test: packages/components/[webkit] › src/anchor/anchor.base.test.ts#L1
packages/components/[webkit] › src/anchor/anchor.base.test.ts took 32.2s
Slow Test: packages/components/[firefox] › src/select/select.base.test.ts#L1
packages/components/[firefox] › src/select/select.base.test.ts took 24.7s
Slow Test: packages/components/[webkit] › src/select/select.base.test.ts#L1
packages/components/[webkit] › src/select/select.base.test.ts took 22.9s
🎭 Playwright Run Summary
3 failed [chromium] › src/avatar/avatar.test.ts:22:1 › With Image ─────────────────────────────────────── [firefox] › src/avatar/avatar.test.ts:22:1 › With Image ──────────────────────────────────────── [webkit] › src/slider-label/slider-label.test.ts:14:1 › With Hide Mark ───────────────────────── 8 flaky [chromium] › src/anchor/anchor.base.test.ts:29:3 › jpAnchor › receive focus when focused programatically [firefox] › src/disclosure/disclosure.test.ts:6:1 › Default ──────────────────────────────────── [firefox] › src/slider/slider.test.ts:6:1 › Default ──────────────────────────────────────────── [firefox] › src/slider/slider.test.ts:14:1 › Vertical ────────────────────────────────────────── [firefox] › src/slider-label/slider-label.test.ts:14:1 › With Hide Mark ──────────────────────── [webkit] › src/anchor/anchor.base.test.ts:29:3 › jpAnchor › receive focus when focused programatically [webkit] › src/avatar/avatar.test.ts:22:1 › With Image ───────────────────────────────────────── [webkit] › src/radio-group/radio-group.test.ts:30:1 › Read-only ──────────────────────────────── 6 skipped 478 passed (4.4m)
🎭 Playwright Run Summary
1 flaky [webkit] › src/anchor/anchor.base.test.ts:29:3 › jpAnchor › receive focus when focused programatically 6 skipped 488 passed (3.7m)

Artifacts

Produced during runtime
Name Size
jupyter-ui-test Expired
3.19 MB