Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #7474

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update README.md #7474

wants to merge 3 commits into from

Conversation

hackit-coder
Copy link

Steps to host Jpyter as web interface on Google, Mozilla etc.

Steps to host Jpyter as web interface on Google, Mozilla etc.
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Binder 👈 Launch a Binder on branch hackit-coder/notebook/patch-2

@hackit-coder
Copy link
Author

Hello anyone there

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instructions are incorrect for a number of reasons:

  • the port 8888 may be taken and a different port would be used instead
  • usually there is no need to open a browser - the command above will open the default browser
  • localhost may not work on specific systems and instead using 127.0.0.1 may be needed
  • the URL above will not include the token needed to login and this token will be different each time

Each PR should address an issue. This PR is not linked to any issue. In future I would encourage you to:

  • open an issue first to discuss potential enhancements
  • if you are looking for a way to contribute, looking through the issues and picking up something tagged as good first issue :)

@hackit-coder
Copy link
Author

Ok changed it a bit

@hackit-coder
Copy link
Author

@krassowski can you check

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not convinced that this is an improvement over status quo. These instructions can be still misleading and usually none of these steps are necessary as a browser with the auto-generated temporary redirect file (which is also safer than typing in a token) will automatically open.

Maybe describing what would typically happen (that browser would open etc) and that if it does not then user should open and copy-paste URL could be more useful?

README.md Outdated
Comment on lines 82 to 84
1. Open a web browser (e.g., Google Chrome, Mozilla Firefox).
2. Type: `http://localhost:'host number'` in the address baralong with the login token issued.
3. Press Enter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baralong?

Done changes as requested and fixed changes. PS: Please accept my first contribution.
@hackit-coder
Copy link
Author

Updated it in the previous commit, it' bar along not baralong my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants