Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore close and shutdown confirmation dialog #7430

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sai-chand04
Copy link

issue: #7398

This pull request restore the close and shutdown confirmation dialog.

Copy link
Contributor

Binder 👈 Launch a Binder on branch sai-chand04/notebook/main

// Shut the kernel down, without confirmation
await commands.execute('notebook:shutdown-kernel', { activate: false });
window.close();
const confirm = window.confirm(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sai-chand04 for working on this.

As discussed in #7398, the idea was to introduce a setting to let users override the default behavior. Which does not seem to be the case here for now.

@sai-chand04
Copy link
Author

Hi @jtpio, thank you for your feedback; I’m still working on introducing the setting to allow users to override the default behavior, as discussed in #7398. For now, I’ll keep this in draft status until the setting is fully implemented. I’ll keep you updated on the progress.

@sai-chand04 sai-chand04 marked this pull request as draft July 29, 2024 10:18
@jtpio
Copy link
Member

jtpio commented Oct 15, 2024

@sai-chand04 just checking if you are still interested in finishing the PR?

Otherwise it's fine, we can try to pick it up from there and add the handling of the settings. Thanks for working on this!

@sai-chand04
Copy link
Author

Hi @jtpio, sorry for the delay i was fully occupied with my acadimic works. If possible could you please pick this issue.
thank you so much @jtpio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Close and Shut Down Notebook" menu command discards state without confirmation
3 participants