Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown2asciidoc function for pandoc >= 3.0 (closes #2017) #2152

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

thomasjm
Copy link
Contributor

@thomasjm thomasjm commented May 30, 2024

Pass different arguments to pandoc depending on whether the version is >= 3.0, to fix #2017.

@thomasjm thomasjm force-pushed the fix-asciidoc branch 2 times, most recently from 33f36f3 to d00d056 Compare May 30, 2024 22:19
@takluyver
Copy link
Member

The fix looks good to me, but I think the asciidoc tests should be extended to check for Markdown cells. The notebook used in test_export already has Markdown cells, but the test still passes if they're missing from the output.

(I'm also kind of surprised that nbconvert carries on if pandoc fails, but that's a bigger question)

@thomasjm
Copy link
Contributor Author

thomasjm commented Aug 6, 2024

Okay, added a test. I manually confirmed that the new test fails without the fix in this branch.

@takluyver takluyver merged commit 9c65025 into jupyter:main Aug 7, 2024
23 checks passed
@takluyver
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbconvert export omits markdown cells
3 participants