Add upper bounds to dependencies #1741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've been trying to avoid preemptive upper bounds, after reading this blog post |
|
I agree, i think it's the less harmful options, but require developers to
do as little unnecessary breaking changes as possible.
(from mobile phone)
Op za 2 apr. 2022 03:15 schreef Steven Silvester ***@***.***>:
… We've been trying to avoid preemptive upper bounds, after reading this blog
post <https://iscinumpy.dev/post/bound-version-constraints/>
—
Reply to this email directly, view it on GitHub
<#1741 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANPEPMBY6YYOH42DE5FCHLVC6NUFANCNFSM5R23XLLQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I think breaking changes will happen either way, but if we have pins then the users have less options to solve their local environments. |
|
Please feel free to close my PR if you don't think that change is relevant. Should we at least consider adding an upper bound on Jinja2 for the next minor release? They don't follow semver and they recommend pinning it. |
|
Yeah, the jinja situation is a mess, I do think we should pin that one... |
|
Replaced by #1751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1740