Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nbagg matplotlib backend (WIP) #75

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maartenbreddels
Copy link
Contributor

@maartenbreddels maartenbreddels commented May 29, 2020

This would solve jupyter/nbconvert#1081 and would also make the old legacy nbagg backend work with nbconvert and voila (at least render it).

However, I cannot get it to work, the backend does not send me back the image, which then should be injected in the div.

Note: if you read this, consider using ipympl instead https://github.com/matplotlib/ipympl

@maartenbreddels
Copy link
Contributor Author

maartenbreddels commented May 29, 2020

It now fails for the right reason, which is that the mime bundle only contains a div, while it should contain an image with the base64 encoded data. This is not implemented because I do not get the message containing the image data.

@maartenbreddels
Copy link
Contributor Author

@tacaswell @martinRenou
Maybe you have ideas on how to fix this? The protocol is a bit hard to digest.

@MSeal
Copy link
Contributor

MSeal commented May 29, 2020

Thanks for opening the WIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants