convert hyphens to underscore for python #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind rebasing your PR on the updated master? |
ianhi
commented
Jun 3, 2020
Comment on lines
+32
to
34
| pip.main(['uninstall', 'jupyter_widget_testwidgets', '-y']) | ||
| except Exception: | ||
| pass |
There was a problem hiding this comment.
should the test fail here if unable to uninstall? i.e. if the hyphen replacement didn't work correctly
There was a problem hiding this comment.
Turns out other things will also fail if the hyphen replacement didn't work so failing here probably isn't necessary
|
I also changed the test python package name to reflect the behavior of entering one name for the github project and then just pressing enter. |
in order to test if the hyphens are being replaced correctly
|
Rebased, broken, and then resuscitated - an exciting 30 minutes. Hopefully I learned a valuable lesson about the importance of testing or something. |
|
@martinRenou thanks for #72 - could you look at this one as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #54
Simpler version of: #70
This allows the typescript package to have hyphens, but converts them to dashes for the python package.