Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the custom widget tutorial for JupyterLab 3.0 #3129

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 17, 2021

Follow-up to #2919

Partially addresses #3128.

Update the initial instructions to mention the commands to develop the widget for JupyterLab 3.0.

Preview: https://ipywidgets--3129.org.readthedocs.build/en/3129/examples/Widget%20Custom.html#Build-and-install-the-widget-for-development

image

@jtpio
Copy link
Member Author

jtpio commented Feb 17, 2021

Leaving as draft for now, since it would be nice to merge jupyter-widgets/widget-ts-cookiecutter#83 first.

@jtpio jtpio added the docs label Feb 17, 2021
@jtpio jtpio added this to the 8.0 milestone Feb 17, 2021
@jtpio
Copy link
Member Author

jtpio commented Mar 5, 2021

Leaving as draft for now, since it would be nice to merge jupyter-widgets/widget-ts-cookiecutter#83 first.

Marking as ready for review now that the cookiecutter master branch is for JupyterLab 3.0.

@jtpio jtpio marked this pull request as ready for review March 5, 2021 12:12
Copy link
Contributor

@ianhi ianhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Given that jlpm will always be available in the ipyemail env this is good to go, but the comments below may be worth considering

docs/source/examples/Widget Custom.ipynb Outdated Show resolved Hide resolved
docs/source/examples/Widget Custom.ipynb Outdated Show resolved Hide resolved
@jtpio
Copy link
Member Author

jtpio commented Mar 10, 2021

Thanks @ianhi for the review 👍

The two comments above have been addressed. Happy to iterate on this in follow-up PRs to fully fix #3128.

@jtpio jtpio merged commit 0669b8d into jupyter-widgets:master Mar 10, 2021
@jtpio jtpio deleted the tutorial-lab3 branch March 10, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants