Add CLI --allow-origin (CORS) #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
force-pushed
the
allow-origin
branch
2 times, most recently
from
3b7d120
to
7a964d7
Compare
davidbrochart
force-pushed
the
allow-origin
branch
from
7a964d7
to
72a90cb
Compare
rakhmaevao
reviewed
Nov 6, 2024
| open_browser: bool = False, | ||
| query_params: Dict[str, Any] | None = None, | ||
| debug: bool | None = None, | ||
| middlewares: Sequence[Callable[..., ASGI3Application] | dict[str, Any]] = (), | ||
| ) -> None: | ||
| if allow_origin: |
There was a problem hiding this comment.
At this point, allow_origin is a string, not a tuple. Should it be cast to a tuple before configuring the middleware?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.