Remove asyncio reader when quitting terminal (#411)

jupyter-server · May 13, 2024 · d5a5b17 · d5a5b17
1 parent 5b15a32
commit d5a5b17
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/plugins/terminals/fps_terminals/server.py b/plugins/terminals/fps_terminals/server.py
@@ -40,6 +40,7 @@ def on_output():
                 self.data_or_disconnect = self.p_out.read(65536).decode()
                 self.event.set()
             except Exception:
+                os.close(self.fd)
                 self.loop.remove_reader(self.p_out)
                 self.data_or_disconnect = None
                 self.event.set()
@@ -74,3 +75,4 @@ def quit(self, websocket):
             self.websockets.remove(websocket)
         if not self.websockets:
             os.close(self.fd)
+            self.loop.remove_reader(self.p_out)