Return HTTP 400 when attempting to post an event with an unregistered schema #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afshin
force-pushed
the
unregistered-event
branch
from
c514bd4
to
f5bb5a8
Compare
afshin
force-pushed
the
unregistered-event
branch
3 times, most recently
from
fd89dfd
to
d1c7a54
Compare
afshin
force-pushed
the
unregistered-event
branch
from
d1c7a54
to
21da85d
Compare
afshin
force-pushed
the
unregistered-event
branch
from
80307ab
to
541c9cf
Compare
afshin
force-pushed
the
unregistered-event
branch
from
541c9cf
to
26d9115
Compare
afshin
force-pushed
the
unregistered-event
branch
from
fff55ce
to
027bb33
Compare
afshin
force-pushed
the
unregistered-event
branch
from
027bb33
to
d182961
Compare
Zsailer
reviewed
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a
POSTis made to/api/eventswith a well-formed event that has a schema that hasn't been registered with theevent_logger, the REST API returns an HTTP 500 error, but in every case I could find where an exception is raised, it comes from bad input, so it should be an HTTP 400 error.depends on: jupyter/jupyter_events#101