Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid showing "No answer for 5s" when shutdown is slow #1320

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Sep 4, 2023

if shutdown is confirmed with ctrl-C twice and shutdown took more than 5s, logs would erroneously show "resuming operation..." before finally shutting down.

if shutdown is confirmed with ctrl-C twice, if shutdown took more than 5s, logs would erroneously show "resuming operation..." before finally shutting down.
@minrk minrk added the bug label Sep 4, 2023
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 1d9a77a into jupyter-server:main Sep 4, 2023
31 of 34 checks passed
@minrk minrk deleted the notice-shutting-down branch September 5, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants