Don't repeat extension name in metrics

jupyter-server · Nov 4, 2024 · 36e8ad6 · 36e8ad6
1 parent 3bb172a
commit 36e8ad6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/jupyter_server/prometheus/metrics.py b/jupyter_server/prometheus/metrics.py
@@ -53,7 +53,7 @@
 
 # New prometheus metrics that do not exist in notebook v6 go here
 SERVER_INFO = Info("jupyter_server", "Jupyter Server Version information")
-SERVER_EXTENSION_INFO = Info("jupyter_server_extension", "Jupyter Server Extensiom Version Information", ["extension_name", "package_name", "version", "enabled"])
+SERVER_EXTENSION_INFO = Info("jupyter_server_extension", "Jupyter Server Extensiom Version Information", ["name", "version", "enabled"])
 
 __all__ = [
     "HTTP_REQUEST_DURATION_SECONDS",

diff --git a/jupyter_server/serverapp.py b/jupyter_server/serverapp.py
@@ -2705,8 +2705,7 @@ def init_metrics(self) -> None:
 
         for k, ext in self.extension_manager.extensions.items():
             SERVER_EXTENSION_INFO.labels(
-                package_name=k,
-                extension_name=ext.name,
+                name=ext.name,
                 version=ext.version,
                 enabled=str(ext.enabled).lower()
             )