Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment variables leaking into the parent environment #1078

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Fix environment variables leaking into the parent environment #1078

merged 5 commits into from
Apr 9, 2024

Conversation

krassowski
Copy link
Member

References

Closes #1076

Code changes

Use os._Environ.copy instead of copy.copy to copy the environment

User-facing changes

None

Backwards-incompatible changes

None

@krassowski krassowski added the bug Something isn't working label Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/fix-env-variables

@krassowski krassowski marked this pull request as ready for review April 9, 2024 16:58
@krassowski krassowski merged commit b159ae2 into jupyter-lsp:main Apr 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment variables set for lsp servers leak into the server/kernel
1 participant
@krassowski