Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Monitoring guide to use newest helm charts and add config required by the version bump #258

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PandaFood
Copy link

Updated the versions in the monitoring guide to the newest available so it would work on an up to date kubernetes cluster. Added a minimal config file for loki which was required for the updated helm chart.

I also changed the label selector for kubernetes app names as they are exported as "app" instead of "app.kubernetes.io/name" nowadays.

@J12934
Copy link
Member

J12934 commented Nov 11, 2024

Awesome thank you for the PR.
Did you have a look at the (newer?) loki-stack chart?
If i get it correctly the loki chart got so complicated because for simple usecases they recommend the loki-stack chart which is more of a all in one chart combinding a single instance loki with promtail. That sounds like it would be a better fit for the guide?

https://artifacthub.io/packages/helm/grafana/loki-stack

@PandaFood
Copy link
Author

I only looked in to it slightly, but it looks like they've turned around on that one again. According to many issues and this post, grafana/helm-charts#3149 (comment) , the loki-stack chart is depricated, but they're generally not being very clear

@J12934
Copy link
Member

J12934 commented Nov 13, 2024

@PandaFood ah ok :(
Was hoping we could simplify this a bit, thank your for looking into this 👍
Will try this out over the next couple of days and merge it then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants