Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Introduce JuniferConnectivityMeasure #348

Merged
merged 10 commits into from
Jul 19, 2024

Conversation

synchon
Copy link
Member

@synchon synchon commented Jun 14, 2024

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR introduces JuniferConnectivityMeasure, tailored nilearn.connectome.ConnectivityMeasure for junifer. This sets sklearn.covariance.EmpiricalCovariance as the default covariance estimator and correlation as the default connectivity matrix kind, which is what junifer users mostly do. It also sets the ground to add custom connectivity matrix kinds and correlation metrics. Required by #333 and #335 as of now.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 93.38843% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.67%. Comparing base (f80c685) to head (6b792b9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   88.58%   88.67%   +0.08%     
==========================================
  Files         114      115       +1     
  Lines        5028     5138     +110     
  Branches      983     1019      +36     
==========================================
+ Hits         4454     4556     +102     
- Misses        418      422       +4     
- Partials      156      160       +4     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 88.67% <93.38%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docs/conf.py 100.00% <ø> (ø)
junifer/external/nilearn/__init__.py 100.00% <100.00%> (ø)
...ivity/crossparcellation_functional_connectivity.py 100.00% <100.00%> (ø)
...nnectivity/edge_functional_connectivity_parcels.py 100.00% <ø> (ø)
...nnectivity/edge_functional_connectivity_spheres.py 89.47% <ø> (ø)
...ional_connectivity/functional_connectivity_base.py 96.42% <100.00%> (+0.13%) ⬆️
...al_connectivity/functional_connectivity_parcels.py 100.00% <ø> (ø)
...al_connectivity/functional_connectivity_spheres.py 100.00% <ø> (ø)
...r/external/nilearn/junifer_connectivity_measure.py 92.52% <92.52%> (ø)

Copy link

github-actions bot commented Jun 14, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-19 10:27 UTC

@synchon synchon force-pushed the feat/junifer-connectivity-measure branch 2 times, most recently from 2d20601 to b837fc1 Compare June 21, 2024 09:44
@synchon synchon requested a review from fraimondo July 3, 2024 10:28
@synchon synchon added enhancement New feature or request marker Issues or pull requests related to markers labels Jul 3, 2024
Copy link
Contributor

@fraimondo fraimondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require a new major I think.

@synchon synchon force-pushed the feat/junifer-connectivity-measure branch from a0c23d8 to c92a1a7 Compare July 18, 2024 04:36
@synchon synchon added this to the 0.0.5 (alpha 4) milestone Jul 18, 2024
@synchon synchon force-pushed the feat/junifer-connectivity-measure branch 2 times, most recently from edb210e to 767d14f Compare July 19, 2024 04:06
@synchon synchon force-pushed the feat/junifer-connectivity-measure branch from 9d20190 to 6b792b9 Compare July 19, 2024 08:31
@synchon synchon merged commit e016a7d into main Jul 19, 2024
26 of 28 checks passed
@synchon synchon deleted the feat/junifer-connectivity-measure branch July 19, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request marker Issues or pull requests related to markers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants