-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Introduce JuniferConnectivityMeasure
#348
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 88.58% 88.67% +0.08%
==========================================
Files 114 115 +1
Lines 5028 5138 +110
Branches 983 1019 +36
==========================================
+ Hits 4454 4556 +102
- Misses 418 422 +4
- Partials 156 160 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
2d20601
to
b837fc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require a new major I think.
a0c23d8
to
c92a1a7
Compare
edb210e
to
767d14f
Compare
…ConnectivityMeasure
9d20190
to
6b792b9
Compare
This PR introduces
JuniferConnectivityMeasure
, tailorednilearn.connectome.ConnectivityMeasure
for junifer. This setssklearn.covariance.EmpiricalCovariance
as the default covariance estimator andcorrelation
as the default connectivity matrix kind, which is what junifer users mostly do. It also sets the ground to add custom connectivity matrix kinds and correlation metrics. Required by #333 and #335 as of now.