Skip to content

Commit

Permalink
chore: 🤖 unify build commands + package upgrades
Browse files Browse the repository at this point in the history
Also fixed several breakge made by the move to nx 19
  • Loading branch information
shaharkazaz committed Jun 22, 2024
1 parent 7a11061 commit 5203205
Show file tree
Hide file tree
Showing 18 changed files with 3,667 additions and 4,230 deletions.
9 changes: 7 additions & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,18 @@
"groups": ["builtin", "external", "internal", "parent", "sibling"],
"newlines-between": "always"
}
]
],
"@typescript-eslint/no-extra-semi": "error",
"no-extra-semi": "off"
}
},
{
"files": ["*.js", "*.jsx"],
"extends": ["plugin:@nx/javascript"],
"rules": {}
"rules": {
"@typescript-eslint/no-extra-semi": "error",
"no-extra-semi": "off"
}
},
{
"files": ["**/*.spec.ts", "**/mocks.ts", "**/test-setup.ts"],
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,12 @@ jobs:
- name: Setup
uses: ./.github/actions/step-setup

- name: Run build
- name: Build libs & apps
run: npm run ci:build

- name: Build docs
run: cd docs && npm i && npm run build

test:
runs-on: ubuntu-latest
steps:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,6 @@ Thumbs.db
apps/transloco-playground-e2e/cypress/screenshots/*

.nx/cache
.nx/workspace-data

.nx
3 changes: 0 additions & 3 deletions .husky/commit-msg
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx --no-install commitlint --edit $1
3 changes: 0 additions & 3 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npm run pre-commit
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@
/docs/docs

/.nx/cache

/.nx/workspace-data
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ npm start
## Building

```bash
npm run build:[package]
npm run build [package]
```

Note: Don't use nx directly as some apps might have further building steps
Expand Down
38 changes: 0 additions & 38 deletions CREATE_LIBS.md

This file was deleted.

2 changes: 1 addition & 1 deletion apps/transloco-playground/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"with": "apps/transloco-playground/src/environments/environment.docs.ts"
}
],
"indexFileTransformer": "apps/transloco-playground/index-html-transform.ts",
"indexHtmlTransformer": "apps/transloco-playground/index-html-transform.ts",
"outputHashing": "all"
},
"development": {
Expand Down
Loading

0 comments on commit 5203205

Please sign in to comment.