Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that large integers are multiples of small multipleOf #648

Merged

Conversation

michaelmior
Copy link
Contributor

See mafintosh/is-my-json-valid#192. The issue is that a multipleOf which is between 0 and 1 was not considering larger integers as valid. The tests attached check for this.

@michaelmior michaelmior requested a review from a team as a code owner March 2, 2023 20:03
Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These pass for me. Thanks for the addition!

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests pass for me, but your $schema declarations don't match the versions being tested (copy/paste error I'm sure). I believe what we settled on is that 2019-09 later should have $schema and before that, it should be left out.

@michaelmior
Copy link
Contributor Author

michaelmior commented Mar 8, 2023

@jdesrosiers Whoops! That was indeed a rather careless copy-paste. I think it should be good now!

@jdesrosiers jdesrosiers merged commit 8292706 into json-schema-org:main Mar 8, 2023
@michaelmior michaelmior deleted the small-multiple-large-int branch March 9, 2023 18:26
@michaelmior
Copy link
Contributor Author

Thanks @jdesrosiers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants