Run all DateTimeFormat tests by default #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we need to land an update to the ignore file in js-temporal/temporal-polyfill before we can land this? |
|
Yep, that's correct. @ptomato |
|
Done, at js-temporal/temporal-polyfill#282. |
These were previously omitted because the tc39/proposal-temporal reference code didn't provide a spec-compliant DateTimeFormat object. Now (most of) those compliance issues have been fixed, let's run those tests.
ptomato
force-pushed
the
run-all-dtf-tests
branch
from
34925b7
to
c549dae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously omitted because the tc39/proposal-temporal reference code didn't provide a spec-compliant DateTimeFormat object. Now (most of) those compliance issues have been fixed, let's run those tests.